Source/core/rendering/line/BreakingContextInlineHeaders.h - Issue 128923002: White spaces between nowrap and normal inlines should break the line

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/line/BreakingContextInlineHeaders.h

Issue 128923002: White spaces between nowrap and normal inlines should break the line (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html ('K') | « LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/line/BreakingContextInlineHeaders.h

diff --git a/Source/core/rendering/line/BreakingContextInlineHeaders.h b/Source/core/rendering/line/BreakingContextInlineHeaders.h

index 74eba9d2ab63a4d4e5abb0a2780ff954cd94be73..d5bdc51c7ace159639f866448be9228e30a2918f 100644

--- a/Source/core/rendering/line/BreakingContextInlineHeaders.h

+++ b/Source/core/rendering/line/BreakingContextInlineHeaders.h

@@ -726,6 +726,13 @@ inline bool BreakingContext::handleText(WordMeasurements& wordMeasurements, bool

bool isSVGText = renderText->isSVGInlineText();

+ // If we have left a no-wrap inline and entered an autowrap inline while ignoring spaces

+ // then we need to mark the start of the autowrap inline as a potential linebreak now.

+ if (m_autoWrap && !RenderStyle::autoWrap(m_lastWS) && m_ignoringSpaces) {

+ m_width.commit();

+ m_lineBreak.moveToStartOf(m_current.object());

+ }

if (renderText->style()->hasTextCombine() && m_current.object()->isCombineText() && !toRenderCombineText(m_current.object())->isCombined()) {

RenderCombineText* combineRenderer = toRenderCombineText(m_current.object());

combineRenderer->combineText();