White spaces between nowrap and normal inlines should break the line

White spaces between nowrap and normal inlines should break the line.

If we have left a no-wrap inline and entered an autowrap inline while ignoring
spaces then we need to mark the start of the autowrap inline as a potential line
break now.

BUG=332431
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164834

[leviw_travelin_and_unemployed, 2014-01-08 18:54:07]

The code change looks good. I *think* you want the patch summary as the first
line of your description?

https://codereview.chromium.org/128923002/diff/1/LayoutTests/fast/text/whites...
File LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html (right):

https://codereview.chromium.org/128923002/diff/1/LayoutTests/fast/text/whites...
LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html:21: This test
passes if there is a green square below. It tests that whitespaces at the end of
Why are you changing this test instead of adding one? Was it not testing what it
implied that it did?

https://codereview.chromium.org/128923002/diff/1/LayoutTests/fast/text/whites...
LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html:24: <div
class="pre"><span class="nowrap">xx  </span><span class="normal">
xx</span></div>
Couldn't this be a js test, or at least a ref test?

[igoroliveira, 2014-01-08 19:08:09]

On 2014/01/08 18:54:07, Levi wrote:
> The code change looks good. I *think* you want the patch summary as the first
> line of your description?
>

Yep

>
https://codereview.chromium.org/128923002/diff/1/LayoutTests/fast/text/whites...
> File LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html
(right):
> 
>
https://codereview.chromium.org/128923002/diff/1/LayoutTests/fast/text/whites...
> LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html:21: This
test
> passes if there is a green square below. It tests that whitespaces at the end
of
> Why are you changing this test instead of adding one? Was it not testing what
it
> implied that it did?

Because the inline-whitespace-wrapping-4.html is too simple, however i do not
have a stronger opinion. I created a new test.

> 
>
https://codereview.chromium.org/128923002/diff/1/LayoutTests/fast/text/whites...
> LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-4.html:24: <div
> class="pre"><span class="nowrap">xx  </span><span class="normal">
> xx</span></div>
> Couldn't this be a js test, or at least a ref test?

Done

[leviw_travelin_and_unemployed, 2014-01-09 19:15:24]

Awesome! Ty :) LGTM

[commit-bot: I haz the power, 2014-01-09 19:16:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/128923002/70001

[commit-bot: I haz the power, 2014-01-09 20:52:37]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-09 21:18:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/128923002/70001

[commit-bot: I haz the power, 2014-01-09 22:40:53]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-09 23:04:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/128923002/320001

[commit-bot: I haz the power, 2014-01-10 02:27:47]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2014-01-10 03:49:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/128923002/320001

[commit-bot: I haz the power, 2014-01-10 06:01:23]

Change committed as 164834