Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: src/factory.cc

Issue 1289203003: No longer use js builtins object as receiver for calls into JS. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/execution.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index 11afad45693cee917a62724c8819fc1e3e4ad0ef..43c0f8aac780d007b07a076a906458f8fa3aaefc 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1239,11 +1239,9 @@ Handle<Object> Factory::NewError(const char* maker, const char* message,
// running the factory method, use the exception as the result.
Handle<Object> result;
MaybeHandle<Object> exception;
- if (!Execution::TryCall(fun,
- isolate()->js_builtins_object(),
- arraysize(argv),
- argv,
- &exception).ToHandle(&result)) {
+ if (!Execution::TryCall(fun, undefined_value(), arraysize(argv), argv,
+ &exception)
+ .ToHandle(&result)) {
Handle<Object> exception_obj;
if (exception.ToHandle(&exception_obj)) return exception_obj;
return undefined_value();
@@ -1263,11 +1261,9 @@ Handle<Object> Factory::NewError(const char* constructor,
// running the factory method, use the exception as the result.
Handle<Object> result;
MaybeHandle<Object> exception;
- if (!Execution::TryCall(fun,
- isolate()->js_builtins_object(),
- arraysize(argv),
- argv,
- &exception).ToHandle(&result)) {
+ if (!Execution::TryCall(fun, undefined_value(), arraysize(argv), argv,
+ &exception)
+ .ToHandle(&result)) {
Handle<Object> exception_obj;
if (exception.ToHandle(&exception_obj)) return exception_obj;
return undefined_value();
« no previous file with comments | « src/execution.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698