Modified RenderFrameObserver API

content/public/renderer/render_frame_observer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/strings/string16.h"
@@ skipping 84 matching lines @@
                                            const base::string16& stack_trace,
                                            int32 line_number,
                                            int32 severity_level) {}
 
   // Called when a compositor frame has committed.
   virtual void DidCommitCompositorFrame() {}
 
   // Called when the focused node has changed to |node|.
   virtual void FocusedNodeChanged(const blink::WebNode& node) {}
 
+  // Notifications when Performance data becomes available

[Bryan McQuade, 2015/08/14 12:01:41]

for the comment, I'd reference the class name explicitly:
// Notifications when |PerformanceTiming| data becomes available.

+  virtual void OnPerformanceTimingChanged() {}

[Bryan McQuade, 2015/08/14 12:01:40]

in keeping with the other naming, maybe call this DidChangePerformanceTiming?

[Bryan McQuade, 2015/08/14 12:01:41]

In addition to this change, I'd also include the part of the CL where
RenderFrameImpl implements the new callback and invokes this new method on all
of its observers.

+
   // IPC::Listener implementation.
   bool OnMessageReceived(const IPC::Message& message) override;
 
   // IPC::Sender implementation.
   bool Send(IPC::Message* message) override;
 
   RenderFrame* render_frame() const;
   int routing_id() const { return routing_id_; }
 
  protected:
@@ skipping 10 matching lines @@
   RenderFrame* render_frame_;
   // The routing ID of the associated RenderFrame.
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_