Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1289003002: Fix for VALGRIND DrawAtlas test issue. (Closed)

Created:
5 years, 4 months ago by jvanverth1
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for VALGRIND DrawAtlas test issue. Don't pre-alloc color array. Committed: https://skia.googlesource.com/skia/+/1acf250f922a547018bab25676d63f3bb090be71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jvanverth1
5 years, 4 months ago (2015-08-13 17:04:45 UTC) #2
robertphillips
lgtm
5 years, 4 months ago (2015-08-13 18:22:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289003002/1
5 years, 4 months ago (2015-08-13 18:23:17 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-13 18:30:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289003002/1
5 years, 4 months ago (2015-08-13 18:52:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1acf250f922a547018bab25676d63f3bb090be71
5 years, 4 months ago (2015-08-13 18:53:41 UTC) #11
bsalomon
5 years, 4 months ago (2015-08-13 19:00:34 UTC) #12
Message was sent while issue was closed.
On 2015/08/13 18:30:31, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

In general, calling begin() on SkTArray is not guaranteed to return NULL. That
is probably it's own issue in and of itself, but I think here you probably need
to check hasColors.

Powered by Google App Engine
This is Rietveld 408576698