Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1288993002: Revert of [Android] Remove android_commands and android_testrunner. (Closed)

Created:
5 years, 4 months ago by csharp
Modified:
5 years, 4 months ago
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mikecase (-- gone --), rnephew (Reviews Here), yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Remove android_commands and android_testrunner. (patchset #3 id:40001 of https://codereview.chromium.org/1290773009/ ) Reason for revert: This seems to have broken the Google Chrome Linux x64 build Output: FAILED: cd ../../content; python ../tools/isolate_driver.py check --isolated "../out/Release/telemetry_gpu_unittests.isolated" --isolate "telemetry_gpu_unittests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Release " --extra-variable "version_full=46.0.2482.0" --config-variable "CONFIGURATION_NAME=Release" --config-variable "OS=linux" --config-variable "asan=0" --config-variable "branding=Chrome" --config-variable "chromeos=0" --config-variable "component=static_library" --config-variable "disable_nacl=0" --config-variable "enable_pepper_cdms=1" --config-variable "enable_plugins=1" --config-variable "fastbuild=0" --config-variable "icu_use_data_file_flag=1" --config-variable "internal_gles2_conform_tests=0" --config-variable "kasko=0" --config-variable "libpeer_target_type=static_library" --config-variable "lsan=0" --config-variable "msan=0" --config-variable "target_arch=x64" --config-variable "tsan=0" --config-variable "use_custom_libcxx=0" --config-variable "use_instrumented_libraries=0" --config-variable "use_prebuilt_instrumented_libraries=0" --config-variable "use_openssl=1" --config-variable "use_ozone=0" --config-variable "use_x11=1" --config-variable "v8_use_external_startup_data=1" Failed to find an input file: /b/build/slave/google-chrome-rel-linux_64/build/src/third_party/android_testrunner/ is not a directory but ends with "/" Original issue's description: > [Android] Remove android_commands and android_testrunner. > > Good riddance. > > BUG=267773 > > Committed: https://crrev.com/d71baced2e55f9f102189c490908e3c631a790e2 > Cr-Commit-Position: refs/heads/master@{#343210} TBR=craigdh@chromium.org,nednguyen@google.com,perezju@chromium.org,sullivan@chromium.org,thakis@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/b0e8b5904780100ed6793e4cca9215e3c453b857 Cr-Commit-Position: refs/heads/master@{#343219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3731 lines, -42 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download
M build/android/gyp/util/build_device.py View 1 chunk +2 lines, -5 lines 0 comments Download
M build/android/provision_devices.py View 2 chunks +7 lines, -1 line 0 comments Download
A build/android/pylib/android_commands.py View 1 chunk +1976 lines, -0 lines 0 comments Download
A build/android/pylib/android_commands_unittest.py View 1 chunk +191 lines, -0 lines 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/pylib/device/decorators.py View 2 chunks +12 lines, -0 lines 0 comments Download
M build/android/pylib/device/decorators_test.py View 5 chunks +77 lines, -0 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 2 chunks +7 lines, -0 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 3 chunks +12 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 3 chunks +4 lines, -13 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +2 lines, -0 lines 0 comments Download
A build/android/pylib/system_properties.py View 1 chunk +40 lines, -0 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/android_testrunner/LICENSE View 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/android_testrunner/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/android_testrunner/README.chromium View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/android_testrunner/adb_interface.py View 1 chunk +522 lines, -0 lines 0 comments Download
A third_party/android_testrunner/am_instrument_parser.py View 1 chunk +169 lines, -0 lines 0 comments Download
A third_party/android_testrunner/errors.py View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/android_testrunner/logger.py View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/android_testrunner/patch.diff View 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/android_testrunner/run_command.py View 1 chunk +192 lines, -0 lines 0 comments Download
M tools/android/appstats.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/checkperms/checkperms.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/cygprofile/profile_android_startup.py View 7 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
csharp
Created Revert of [Android] Remove android_commands and android_testrunner.
5 years, 4 months ago (2015-08-13 16:49:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288993002/1
5 years, 4 months ago (2015-08-13 16:49:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 16:50:48 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 16:51:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0e8b5904780100ed6793e4cca9215e3c453b857
Cr-Commit-Position: refs/heads/master@{#343219}

Powered by Google App Engine
This is Rietveld 408576698