Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 1288953006: include <OpenGL/gl.h> instead of <OpenGL/GL.h> (Closed)

Created:
5 years, 4 months ago by ukai
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include <OpenGL/gl.h> instead of <OpenGL/GL.h> actual file names in OpenGL.framework/Headers is gl.h, not GL.h, so <OpenGL/GL.h> may fail on case-sensitive filesystem. BUG=521449 Committed: https://crrev.com/c1f30005558972165dc84fc2f0738801e5675d6a Cr-Commit-Position: refs/heads/master@{#343851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/gpu/image_transport_surface_overlay_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
ukai
5 years, 4 months ago (2015-08-17 04:05:15 UTC) #2
ukai
5 years, 4 months ago (2015-08-18 05:16:46 UTC) #4
Ken Russell (switch to Gerrit)
lgtm
5 years, 4 months ago (2015-08-18 05:23:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288953006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288953006/1
5 years, 4 months ago (2015-08-18 07:01:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 07:55:57 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 07:56:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1f30005558972165dc84fc2f0738801e5675d6a
Cr-Commit-Position: refs/heads/master@{#343851}

Powered by Google App Engine
This is Rietveld 408576698