Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 128893003: Move geometry allocator for drawVertices inside autoflush scope. (Closed)

Created:
6 years, 11 months ago by jvanverth1
Modified:
6 years, 11 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Move geometry allocator for drawVertices inside autoflush scope. BUG=skia:1956 Committed: http://code.google.com/p/skia/source/detail?r=12973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/gpu/GrContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jvanverth1
6 years, 11 months ago (2014-01-08 19:51:46 UTC) #1
bsalomon
lgtm, prolly worth doing a search for ACF to make sure there aren't other cases ...
6 years, 11 months ago (2014-01-08 19:54:06 UTC) #2
jvanverth1
On 2014/01/08 19:54:06, bsalomon wrote: > lgtm, prolly worth doing a search for ACF to ...
6 years, 11 months ago (2014-01-08 20:00:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/128893003/1
6 years, 11 months ago (2014-01-08 20:03:47 UTC) #4
reed1
if this fixes the nocache bug, can you remove the kSkipGPU from its gm? (gm/vertices.cpp)
6 years, 11 months ago (2014-01-08 20:16:06 UTC) #5
commit-bot: I haz the power
List of reviewers changed. reed@google.com did a drive-by without LGTM'ing!
6 years, 11 months ago (2014-01-08 21:16:18 UTC) #6
reed1
lgtm
6 years, 11 months ago (2014-01-08 21:23:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/128893003/1
6 years, 11 months ago (2014-01-08 21:24:01 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 21:26:12 UTC) #9
Message was sent while issue was closed.
Change committed as 12973

Powered by Google App Engine
This is Rietveld 408576698