Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1288923002: Revert of [runtime] Remove useless IN builtin. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Jarin, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Remove useless IN builtin. (patchset #2 id:20001 of https://codereview.chromium.org/1295433002/ ) Reason for revert: Breaks win32 nosnap Original issue's description: > [runtime] Remove useless IN builtin. > > Similar to DELETE, the IN builtin is just a thin wrapper for %HasElement > and %HasProperty anyway, and cannot be optimized, plus it had a weird > special fast case (which also involved at least one LOAD_IC plus some > intrinsic magic). > > R=yangguo@chromium.org,jarin@chromium.org > > Committed: https://crrev.com/72d60a1e80e81e2e68ca402665e2acbc46c5e471 > Cr-Commit-Position: refs/heads/master@{#30154} TBR=yangguo@chromium.org,jarin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/96e331e2f2c43d53eb475766163b14b093efa4c0 Cr-Commit-Position: refs/heads/master@{#30155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -41 lines) Patch
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +23 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/runtime.js View 2 chunks +16 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +17 lines, -28 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [runtime] Remove useless IN builtin.
5 years, 4 months ago (2015-08-13 13:06:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288923002/1
5 years, 4 months ago (2015-08-13 13:06:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 13:06:52 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 13:07:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96e331e2f2c43d53eb475766163b14b093efa4c0
Cr-Commit-Position: refs/heads/master@{#30155}

Powered by Google App Engine
This is Rietveld 408576698