chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java - Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing files Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarksUriTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenHelperTest.java » ('j') | chrome/browser/android/chrome_jni_registrar.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java

index d1d6dfd87d20f82e84ca3d4ba2b4f031a3b1a8ec..74215b25b1cc425030c41a7dd0240c32dfa2c4c3 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java

@@ -16,11 +16,11 @@ import android.view.View;

import org.chromium.base.ApplicationStatus;

import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.MinAndroidSdkLevel;

-import org.chromium.chrome.browser.BookmarkUtils;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeApplication;

import org.chromium.chrome.browser.ChromeTabbedActivity;

import org.chromium.chrome.browser.IntentHandler;

+import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.TabModel;

import org.chromium.chrome.browser.tabmodel.TabModelUtils;

@@ -265,7 +265,7 @@ public class DocumentModeTest extends DocumentModeTestBase {

Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(URL_1));

intent.setClass(mContext, ChromeLauncherActivity.class);

intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

- intent.putExtra(BookmarkUtils.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);

+ intent.putExtra(ShortcutHelper.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);

mContext.startActivity(intent);

}

};