chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarkNodeUnitTest.java - Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarkNodeUnitTest.java

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing files Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarksUriTest.java » ('j') | chrome/browser/android/chrome_jni_registrar.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarkNodeUnitTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarkNodeUnitTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarkNodeUnitTest.java

index fc3fbb58138d12c71fc117bb7e833921ef8bc941..49f743f8012de26ca8e141d936a7191ed5a8f05e 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarkNodeUnitTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ProviderBookmarkNodeUnitTest.java

@@ -12,7 +12,7 @@ import org.chromium.base.test.util.DisabledTest;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.browser.ChromeBrowserProvider.BookmarkNode;

import org.chromium.chrome.browser.ChromeBrowserProvider.Type;

-import org.chromium.chrome.test.util.browser.BookmarkUtils;

+import org.chromium.chrome.test.util.browser.ShortcutHelper;

import java.util.Random;

@@ -28,9 +28,9 @@ public class ProviderBookmarkNodeUnitTest extends AndroidTestCase {

super.setUp();

mImageBlobs = new byte[][] {

- BookmarkUtils.getIcon("chrome/provider/icon1.png"),

- BookmarkUtils.getIcon("chrome/provider/icon2.png"),

- BookmarkUtils.getIcon("chrome/provider/icon3.png"),

+ ShortcutHelper.getIcon("chrome/provider/icon1.png"),

+ ShortcutHelper.getIcon("chrome/provider/icon2.png"),

+ ShortcutHelper.getIcon("chrome/provider/icon3.png"),

};

for (byte[] icon : mImageBlobs) {