chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java - Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing files Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

index 635f1590be9704708a55ddc252fc5342ee078d55..6985808b5571611aa09b5baa4f31de84ff8c10bc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

@@ -28,7 +28,6 @@ import android.util.Log;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.ApplicationStatus;

import org.chromium.base.TraceEvent;

-import org.chromium.chrome.browser.BookmarkUtils;

import org.chromium.chrome.browser.ChromeApplication;

import org.chromium.chrome.browser.ChromeTabbedActivity;

import org.chromium.chrome.browser.IntentHandler;

@@ -319,7 +318,7 @@ public class ChromeLauncherActivity extends Activity

boolean append = IntentUtils.safeGetBooleanExtra(

getIntent(), IntentHandler.EXTRA_APPEND_TASK, false);

boolean reuse = IntentUtils.safeGetBooleanExtra(

- getIntent(), BookmarkUtils.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, false);

+ getIntent(), ShortcutHelper.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, false);

boolean affiliated = IntentUtils.safeGetBooleanExtra(

getIntent(), IntentHandler.EXTRA_OPEN_IN_BG, false);