Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: chrome/browser/android/shortcut_helper.cc

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test file name Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/shortcut_helper.h" 5 #include "chrome/browser/android/shortcut_helper.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/location.h" 12 #include "base/location.h"
13 #include "base/strings/string16.h" 13 #include "base/strings/string16.h"
14 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
15 #include "chrome/browser/banners/app_banner_settings_helper.h" 15 #include "chrome/browser/banners/app_banner_settings_helper.h"
16 #include "content/public/browser/browser_thread.h" 16 #include "content/public/browser/browser_thread.h"
17 #include "content/public/browser/web_contents.h" 17 #include "content/public/browser/web_contents.h"
18 #include "content/public/common/manifest.h" 18 #include "content/public/common/manifest.h"
19 #include "jni/ShortcutHelper_jni.h" 19 #include "jni/ShortcutHelper_jni.h"
20 #include "ui/gfx/android/java_bitmap.h" 20 #include "ui/gfx/android/java_bitmap.h"
21 #include "ui/gfx/color_analysis.h" 21 #include "ui/gfx/color_analysis.h"
22 #include "url/gurl.h" 22 #include "url/gurl.h"
23 23
24 using content::Manifest; 24 using content::Manifest;
25 25
26 jlong Initialize(JNIEnv* env, jobject obj, jobject java_web_contents) {
27 content::WebContents* web_contents =
28 content::WebContents::FromJavaWebContents(java_web_contents);
29 ShortcutHelper* shortcut_helper = new ShortcutHelper(env, obj, web_contents);
30 return reinterpret_cast<intptr_t>(shortcut_helper);
31 }
32
33 ShortcutHelper::ShortcutHelper(JNIEnv* env,
34 jobject obj,
35 content::WebContents* web_contents)
36 : add_shortcut_pending_(false),
37 data_fetcher_(new ShortcutDataFetcher(web_contents, this)) {
38 java_ref_.Reset(env, obj);
39 }
40
41 ShortcutHelper::~ShortcutHelper() {
42 data_fetcher_->set_weak_observer(nullptr);
43 data_fetcher_ = nullptr;
44 }
45
46 void ShortcutHelper::OnUserTitleAvailable(const base::string16& user_title) {
47 JNIEnv* env = base::android::AttachCurrentThread();
48 ScopedJavaLocalRef<jstring> j_user_title =
49 base::android::ConvertUTF16ToJavaString(env, user_title);
50 Java_ShortcutHelper_onUserTitleAvailable(env,
51 java_ref_.obj(),
52 j_user_title.obj());
53 }
54
55 void ShortcutHelper::OnDataAvailable(const ShortcutInfo& info,
56 const SkBitmap& icon) {
57 JNIEnv* env = base::android::AttachCurrentThread();
58 ScopedJavaLocalRef<jobject> java_bitmap;
59 if (icon.getSize())
60 java_bitmap = gfx::ConvertToJavaBitmap(&icon);
61
62 Java_ShortcutHelper_onIconAvailable(env,
63 java_ref_.obj(),
64 java_bitmap.obj());
65
66 if (add_shortcut_pending_)
67 AddShortcut(info, icon);
68 }
69
70 void ShortcutHelper::Destroy(JNIEnv* env, jobject obj) {
71 delete this;
72 }
73
74 SkBitmap ShortcutHelper::FinalizeLauncherIcon(const SkBitmap& bitmap,
75 const GURL& url) {
76 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
77
78 // Determine a single color to use for the favicon if the favicon that is
79 // returned it is too low quality.
80 SkColor color = color_utils::CalculateKMeanColorOfBitmap(bitmap);
81 int dominant_red = SkColorGetR(color);
82 int dominant_green = SkColorGetG(color);
83 int dominant_blue = SkColorGetB(color);
84
85 // Make the icon acceptable for the Android launcher.
86 JNIEnv* env = base::android::AttachCurrentThread();
87 ScopedJavaLocalRef<jstring> java_url =
88 base::android::ConvertUTF8ToJavaString(env, url.spec());
89 ScopedJavaLocalRef<jobject> java_bitmap;
90 if (bitmap.getSize())
91 java_bitmap = gfx::ConvertToJavaBitmap(&bitmap);
92
93 base::android::ScopedJavaLocalRef<jobject> ref =
94 Java_ShortcutHelper_finalizeLauncherIcon(env,
95 java_url.obj(),
96 java_bitmap.obj(),
97 dominant_red,
98 dominant_green,
99 dominant_blue);
100 return gfx::CreateSkBitmapFromJavaBitmap(gfx::JavaBitmap(ref.obj()));
101 }
102
103 void ShortcutHelper::AddShortcut(JNIEnv* env,
104 jobject obj,
105 jstring j_user_title) {
106 add_shortcut_pending_ = true;
107
108 base::string16 user_title =
109 base::android::ConvertJavaStringToUTF16(env, j_user_title);
110 if (!user_title.empty())
111 data_fetcher_->shortcut_info().user_title = user_title;
112
113 if (data_fetcher_->is_ready()) {
114 // If the fetcher isn't ready yet, the shortcut will be added when it is
115 // via OnDataAvailable();
116 AddShortcut(data_fetcher_->shortcut_info(), data_fetcher_->shortcut_icon());
117 }
118 }
119
120 void ShortcutHelper::AddShortcut(const ShortcutInfo& info,
121 const SkBitmap& icon) {
122 DCHECK(add_shortcut_pending_);
123 if (!add_shortcut_pending_)
124 return;
125 add_shortcut_pending_ = false;
126
127 RecordAddToHomescreen();
128
129 content::BrowserThread::PostTask(
130 content::BrowserThread::IO,
131 FROM_HERE,
132 base::Bind(&ShortcutHelper::AddShortcutInBackgroundWithSkBitmap,
133 info,
134 icon));
135 }
136
137 bool ShortcutHelper::RegisterShortcutHelper(JNIEnv* env) {
138 return RegisterNativesImpl(env);
139 }
140
141 // static 26 // static
142 void ShortcutHelper::AddShortcutInBackgroundWithSkBitmap( 27 void ShortcutHelper::AddShortcutInBackgroundWithSkBitmap(
143 const ShortcutInfo& info, 28 const ShortcutInfo& info,
144 const SkBitmap& icon_bitmap) { 29 const SkBitmap& icon_bitmap) {
145 DCHECK_CURRENTLY_ON(content::BrowserThread::IO); 30 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
146 31
147 // Send the data to the Java side to create the shortcut. 32 // Send the data to the Java side to create the shortcut.
148 JNIEnv* env = base::android::AttachCurrentThread(); 33 JNIEnv* env = base::android::AttachCurrentThread();
149 ScopedJavaLocalRef<jstring> java_url = 34 ScopedJavaLocalRef<jstring> java_url =
150 base::android::ConvertUTF8ToJavaString(env, info.url.spec()); 35 base::android::ConvertUTF8ToJavaString(env, info.url.spec());
(...skipping 15 matching lines...) Expand all
166 java_name.obj(), 51 java_name.obj(),
167 java_short_name.obj(), 52 java_short_name.obj(),
168 java_bitmap.obj(), 53 java_bitmap.obj(),
169 info.display == blink::WebDisplayModeStandalone, 54 info.display == blink::WebDisplayModeStandalone,
170 info.orientation, 55 info.orientation,
171 info.source, 56 info.source,
172 info.theme_color, 57 info.theme_color,
173 info.background_color); 58 info.background_color);
174 } 59 }
175 60
176 void ShortcutHelper::RecordAddToHomescreen() { 61 bool ShortcutHelper::RegisterShortcutHelper(JNIEnv* env) {
177 // Record that the shortcut has been added, so no banners will be shown 62 return RegisterNativesImpl(env);
178 // for this app.
179 content::WebContents* web_contents = data_fetcher_->web_contents();
180 if (!web_contents)
181 return;
182
183 AppBannerSettingsHelper::RecordBannerEvent(
184 web_contents, web_contents->GetURL(),
185 data_fetcher_->shortcut_info().url.spec(),
186 AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
187 base::Time::Now());
188 } 63 }
OLDNEW
« no previous file with comments | « chrome/browser/android/shortcut_helper.h ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698