[Script Injection] Allow whitelisted extensions to inject scripts everywhere

[Script Injection] Allow whitelisted extensions to inject scripts everywhere

Fix a regression where whitelisted extensions couldn't inject content scripts on
other extension pages.

BUG=517370
Committed: https://crrev.com/9808b390b8a36c9ecb81c10dac9d18125713f57d
Cr-Commit-Position: refs/heads/master@{#343930}

[Devlin, 2015-08-17 22:21:49]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-08-17 22:42:35]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[Devlin, 2015-08-17 22:42:36]

Fix + test.  Woo.

[not at google - send to devlin, 2015-08-17 22:47:29]

lgtm

[Devlin, 2015-08-17 23:26:09]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-08-17 23:26:09]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1288893005/#ps40001
(title: "Missing file")

[commit-bot: I haz the power, 2015-08-17 23:26:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288893005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288893005/40001

[commit-bot: I haz the power, 2015-08-18 01:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 01:35:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2015-08-18 15:24:30]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-08-18 15:24:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288893005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288893005/40001

[commit-bot: I haz the power, 2015-08-18 15:59:01]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-08-18 15:59:43]

Patchset 2 (id:??) landed as
https://crrev.com/9808b390b8a36c9ecb81c10dac9d18125713f57d
Cr-Commit-Position: refs/heads/master@{#343930}

[Ryan Hamilton, 2015-08-18 19:19:18]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1285263006/ by rch@chromium.org.

The reason for reverting is: Seems to have broken browser_tests on
Windows-XP-SP3

https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)/builds/39546

[ RUN      ] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages

[416:2484:0818/104836:ERROR:shell_util.cc(1184)] Error getting short (8.3) path
for E:\b\swarm_slave\work\run_tha_testyfglvj\out\Release\browser_tests.exe: The
system cannot find the path specified. (0x3)

[416:2972:0818/104837:WARNING:raw_channel.cc(208)] Shutting down RawChannel with
write buffer nonempty

c:\b\build\slave\win_builder\build\src\chrome\browser\extensions\all_urls_apitest.cc(141):
error: Value of: bystander

  Actual: false

Expected: true

[416:2972:0818/104837:WARNING:raw_channel.cc(208)] Shutting down RawChannel with
write buffer nonempty

[416:2972:0818/104837:WARNING:raw_channel.cc(208)] Shutting down RawChannel with
write buffer nonempty

[416:2484:0818/104837:WARNING:pref_notifier_impl.cc(27)] pref observer found at
shutdown printing.enabled

[416:2484:0818/104837:WARNING:pref_notifier_impl.cc(27)] pref observer found at
shutdown plugins.allow_outdated

[416:2484:0818/104837:WARNING:pref_notifier_impl.cc(27)] pref observer found at
shutdown plugins.always_authorize

[  FAILED  ] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages, where
TypeParam =  and GetParam() =  (1407 ms)
.