Ctrl-Enter on Bookmark bar link should open in the New Tab.

ui/views/controls/button/custom_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/custom_button.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/keycodes/keyboard_codes.h"
@@ skipping 182 matching lines @@
   // Space sets button state to pushed. Enter clicks the button. This matches
   // the Windows native behavior of buttons, where Space clicks the button on
   // KeyRelease and Enter clicks the button on KeyPressed.
   if (event.key_code() == ui::VKEY_SPACE) {
     SetState(STATE_PRESSED);
   } else if (event.key_code() == ui::VKEY_RETURN) {
     SetState(STATE_NORMAL);
     // TODO(beng): remove once NotifyClick takes ui::Event.
     ui::MouseEvent synthetic_event(ui::ET_MOUSE_RELEASED, gfx::Point(),
                                    gfx::Point(), ui::EventTimeForNow(),
-                                   ui::EF_LEFT_MOUSE_BUTTON,
+                                   ui::EF_LEFT_MOUSE_BUTTON | event.flags(),

[sadrul, 2015/08/14 14:52:46]

KeyEvent can have KeyEventFlags, which can mean different things for a
MouseEvent (e.g. KeyEventFlags::EF_IME_FABRICATED_KEY ==
MouseEventFlags::EF_IS_DOUBLE_CLICK). So we should set only a white-listed set
of flags from event.flags().

Also, please add a test.

[Deepak, 2015/08/17 06:32:51]

Done.

                                    ui::EF_LEFT_MOUSE_BUTTON);
     NotifyClick(synthetic_event);
   } else {
     return false;
   }
   return true;
 }
 
 bool CustomButton::OnKeyReleased(const ui::KeyEvent& event) {
   if ((state_ == STATE_DISABLED) || (event.key_code() != ui::VKEY_SPACE))
@@ skipping 135 matching lines @@
   if (!details.is_add && state_ != STATE_DISABLED)
     SetState(STATE_NORMAL);
 }
 
 void CustomButton::OnBlur() {
   if (IsHotTracked())
     SetState(STATE_NORMAL);
 }
 
 }  // namespace views