Specify -install_name of target within solink.

Specify -install_name of target within solink.

R=dpranke@chromium.org,thakis@chromium.org,mark@chromium.org
BUG=345410, 345021
Committed: https://crrev.com/f6982d816ef5a3bb63c1977bfe24663b07c03648
Cr-Commit-Position: refs/heads/master@{#344027}

[Mark Mentovai, 2015-08-18 16:20:26]

https://codereview.chromium.org/1288863005/diff/1/build/toolchain/mac/BUILD.gn
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/1288863005/diff/1/build/toolchain/mac/BUILD.g...
build/toolchain/mac/BUILD.gn:131: link_command = "$ld -shared {{ldflags}}
-Wl,-install_name,@rpath/{{target_output_name}}{{output_extension}} -o $dylib
-Wl,-filelist,$rspfile {{solibs}} {{libs}}"
Does gn let you build up strings with +=? Or can you do link_command =
$link_command + " other stuff"? It might be better to append the component build
stuff to link_command instead of rewriting it.

If not, can you at least get away with if (is_component_build) { link_command =
one_thing } else { link_command = other_thing } ?

[Bons, 2015-08-18 16:28:16]

On 2015/08/18 15:45:14, Bons wrote:

After having lunch and thinking a bit, I think having variable expansion within
ldflags is more elegant and straightforward than this.

Dirk, let me know what you think.

A

[Dirk Pranke, 2015-08-18 19:23:57]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2015-08-18 19:23:57]

I believe crbug.com/345407 *is* {{target_output_name}}, and that bug was from a
time before we added support for that (i.e., the bug is old and we should just
close it).

In other words, this is the solution we had in mind, and is (more or less) what
I'd expect you to write (though we can clean things up a bit w/ the string
concat like Mark suggests).

Does that make sense?

https://codereview.chromium.org/1288863005/diff/1/build/toolchain/mac/BUILD.gn
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/1288863005/diff/1/build/toolchain/mac/BUILD.g...
build/toolchain/mac/BUILD.gn:131: link_command = "$ld -shared {{ldflags}}
-Wl,-install_name,@rpath/{{target_output_name}}{{output_extension}} -o $dylib
-Wl,-filelist,$rspfile {{solibs}} {{libs}}"
On 2015/08/18 16:20:25, Mark Mentovai - out til August wrote:
> Does gn let you build up strings with +=? Or can you do link_command =
> $link_command + " other stuff"? It might be better to append the component
build
> stuff to link_command instead of rewriting it.

Yes, GN supports string concatenation

[Bons, 2015-08-18 20:20:55]

https://codereview.chromium.org/1288863005/diff/1/build/toolchain/mac/BUILD.gn
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/1288863005/diff/1/build/toolchain/mac/BUILD.g...
build/toolchain/mac/BUILD.gn:131: link_command = "$ld -shared {{ldflags}}
-Wl,-install_name,@rpath/{{target_output_name}}{{output_extension}} -o $dylib
-Wl,-filelist,$rspfile {{solibs}} {{libs}}"
On 2015/08/18 19:23:57, Dirk Pranke wrote:
> On 2015/08/18 16:20:25, Mark Mentovai - out til August wrote:
> > Does gn let you build up strings with +=? Or can you do link_command =
> > $link_command + " other stuff"? It might be better to append the component
> build
> > stuff to link_command instead of rewriting it.
> 
> Yes, GN supports string concatenation

Done.

[Dirk Pranke, 2015-08-18 20:25:30]

lgtm

[Bons, 2015-08-18 20:26:36]

The CQ bit was checked by andybons@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:27:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288863005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288863005/20001

[commit-bot: I haz the power, 2015-08-18 21:05:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-18 21:05:41]

Patchset 2 (id:??) landed as
https://crrev.com/f6982d816ef5a3bb63c1977bfe24663b07c03648
Cr-Commit-Position: refs/heads/master@{#344027}