Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1288863004: fix pathops fuzz failures (Closed)

Created:
5 years, 4 months ago by caryclark
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix pathops fuzz failures If a curve has the identical start and control points, the initial or final tangent can't be trivally determined. The perpendicular to the tangent is used to measure coincidence. Add logic for cubics, quadratics, and conics, to use the secondary control points or the end points if the initial control point alone can't determine the tangent. Add debugging (currently untriggered by exhaustive testing) to detect zero-length tangents which are not at the curve endpoints. Increase the number of temporary intersecions gathered from 10 to 12 but reduce the max passed in by cubic intersection from 27 to 12. Also, add checks if the max passed exceeds the storage allocated. When cleaning up parallel lines, choose the intersection which is on the end of both segments over the intersection which is on the end of a single segment. TBR=reed@google.com BUG=425140, 516266 Committed: https://skia.googlesource.com/skia/+/94c902e63d77641cadd76155c2b248d04f63b560

Patch Set 1 #

Patch Set 2 : fix sign mismatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -7 lines) Patch
M src/pathops/SkDLineIntersection.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M src/pathops/SkIntersections.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/pathops/SkIntersections.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288863004/1
5 years, 4 months ago (2015-08-18 13:46:43 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1018) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 4 months ago (2015-08-18 13:47:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288863004/20001
5 years, 4 months ago (2015-08-18 14:06:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/94c902e63d77641cadd76155c2b248d04f63b560
5 years, 4 months ago (2015-08-18 14:12:46 UTC) #7
Will Harris
4 years, 6 months ago (2016-06-08 21:17:45 UTC) #8
Message was sent while issue was closed.
On 2015/08/18 14:12:46, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/94c902e63d77641cadd76155c2b248d04f63b560

Why was this CL committed direct without review?

Powered by Google App Engine
This is Rietveld 408576698