Chromium Code Reviews Chromium Code Reviews
Issue
1288823004:
Reland #1: Fix the mechanism by which Blink determines OSX version number. (Closed)
DescriptionReland #1: Fix the mechanism by which Blink determines OSX version number.
The newly added test VersionUtilMac.AppKitVersions had a logic error. It tried
to assert that IsOSMavericksOrEarlier() evalutes to false on 10.8 and 10.9.
Original issue's description:
> Fix the mechanism by which Blink determines OSX version number.
>
> Previously, Blink was checking NSAppKitVersionNumber against a compile time
> constant. This mechanism doesn't work (see the bug for more details). This CL
> converts the logic to use the same mechanism that Chromium uses.
>
> BUG=521034
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200708
TBR=thakis@chromium.org
BUG=521034
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200839
Patch Set 1 : Copy of original CL. #Patch Set 2 : Fix logic error in unit test. #
Messages
Total messages: 3 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
