Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288793003: WebUSB: Create a requestDevice method separate from getDevice. (Closed)

Created:
5 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebUSB: Create a requestDevice method separate from getDevice. This change reflects an update I just made to the spec to define a separate requestDevice() method that prompts the user to select a single device vs. getDevices() that returns the devices the origin currently has access to. BUG=492204 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200433

Patch Set 1 #

Patch Set 2 : Update stale reference in modules.gypi. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -68 lines) Patch
M Source/modules/modules.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webusb/USB.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/webusb/USB.cpp View 3 chunks +41 lines, -24 lines 0 comments Download
M Source/modules/webusb/USB.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webusb/USBDevice.h View 2 chunks +7 lines, -1 line 0 comments Download
D Source/modules/webusb/USBDeviceEnumerationOptions.idl View 1 chunk +0 lines, -9 lines 0 comments Download
A + Source/modules/webusb/USBDeviceRequestOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/modules/webusb/WebUSBClient.h View 2 chunks +7 lines, -2 lines 0 comments Download
D public/platform/modules/webusb/WebUSBDeviceEnumerationOptions.h View 1 chunk +0 lines, -20 lines 0 comments Download
A + public/platform/modules/webusb/WebUSBDeviceRequestOptions.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 4 months ago (2015-08-12 21:28:21 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 4 months ago (2015-08-12 21:33:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288793003/20001
5 years, 4 months ago (2015-08-12 21:44:22 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 22:39:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200433

Powered by Google App Engine
This is Rietveld 408576698