Adding visitors to regurgitate expression types or reset them.

test/cctest/expression-type-collector.cc

+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/v8.h"
+
+#include "test/cctest/expression-type-collector.h"
+
+#include "src/ast.h"
+#include "src/codegen.h"
+#include "src/scopes.h"
+
+namespace v8 {
+namespace internal {
+namespace {
+
+struct {
+  AstNode::NodeType type;
+  const char* name;
+} NodeTypeNameList[] = {
+#define DECLARE_VISIT(type)   \
+  { AstNode::k##type, #type } \
+  ,
+    AST_NODE_LIST(DECLARE_VISIT)
+#undef DECLARE_VISIT
+};
+}
+
+
+void ExpressionTypeCollector::Run(CompilationInfo* info,
+                                  ZoneVector<ExpressionTypeEntry>* dst) {
+  ExpressionTypeCollector* visitor =

[rossberg, 2015/08/20 16:34:26]

Same here, no reason for heap allocation.

[bradn, 2015/08/20 21:35:47]

Done.

+      new (info->zone()) ExpressionTypeCollector(info);
+  dst->clear();
+  visitor->result_ = dst;
+  visitor->VisitAll();
+}
+
+
+void ExpressionTypeCollector::VisitExpression(Expression* expression) {
+  ExpressionTypeEntry e;
+  e.depth = depth();
+  VariableProxy* proxy = expression->AsVariableProxy();
+  if (proxy) {
+    e.name = proxy->raw_name();
+  }
+  e.bounds = expression->bounds();
+  AstNode::NodeType type = expression->node_type();
+  e.kind = "unknown";
+  for (size_t i = 0; i < arraysize(NodeTypeNameList); ++i) {
+    if (NodeTypeNameList[i].type == type) {
+      e.kind = NodeTypeNameList[i].name;
+      break;
+    }
+  }
+  result_->push_back(e);
+}
+
+
+ExpressionTypeCollector::ExpressionTypeCollector(CompilationInfo* info)
+    : AstExpressionVisitor(info) {}
+}
+}