Issue 1288743002: A few more spurious cleanups on ApplicationImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1288743002: A few more spurious cleanups on ApplicationImpl. (Closed)

Created:
5 years, 4 months ago by Ben Goodger (Google)

Modified:
5 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

A few more spurious cleanups on ApplicationImpl. R=sky@chromium.org http://crbug.com/519583 Committed: https://crrev.com/47fa58e5f440daecb1e81ed407224042611bb562 Cr-Commit-Position: refs/heads/master@{#343094}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -26 lines)			Patch
M	mojo/application/public/cpp/application_impl.h	View	3 chunks	+21 lines, -12 lines	0 comments	Download
M	mojo/application/public/cpp/lib/application_impl.cc	View	2 chunks	+7 lines, -12 lines	0 comments	Download
M	mojo/application/public/cpp/lib/application_test_base.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288743002/1

5 years, 4 months ago (2015-08-12 20:09:13 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-12 21:10:51 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/47fa58e5f440daecb1e81ed407224042611bb562
Cr-Commit-Position: refs/heads/master@{#343094}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages