Add hash to OFC pasteboard change detection

Add hash to OFC pasteboard change detection

Due to a bug in iOS SDK, the change count is not enough to detect
pasteboard change after a reboot.

BUG=510364
Committed: https://crrev.com/80ac2af9f7a302e7a3e3d71a15fd070838f4ef2d
Cr-Commit-Position: refs/heads/master@{#343189}

[Olivier, 2015-08-12 16:58:00]

olivierrobin@chromium.org changed reviewers:
+ jif@chromium.org

[Olivier, 2015-08-12 16:58:00]

I need to fix the unittests but you can take a first look.

[Olivier, 2015-08-13 09:01:38]

olivierrobin@chromium.org changed reviewers:
+ droger@chromium.org

[droger, 2015-08-13 09:57:00]

https://codereview.chromium.org/1288733002/diff/70001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.h (right):

https://codereview.chromium.org/1288733002/diff/70001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.h:42: void
LoadFromUserDefaults();
Don't put your new functions in the middle of the "ClipboardRecentContent
implementation" section.

[Olivier, 2015-08-13 11:33:03]

Done, thanks

https://codereview.chromium.org/1288733002/diff/70001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.h (right):

https://codereview.chromium.org/1288733002/diff/70001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.h:42: void
LoadFromUserDefaults();
On 2015/08/13 09:57:00, droger wrote:
> Don't put your new functions in the middle of the "ClipboardRecentContent
> implementation" section.

Done.

[Olivier, 2015-08-13 11:33:13]

Done, thanks

[droger, 2015-08-13 11:42:21]

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.h (right):

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.h:44: 
Remove blank line.

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.mm (right):

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.mm:187: bool
not_rebooted = uptime > GetClipboardContentAge();
Optional: should we early return here if (not_rebooted && change_count_changed)?

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.mm:194: BOOL
md5_changed = ![md5 isEqualToData:last_pasteboard_entry_md5_];
What happens if there is a collision? Is this a privacy issue?

[droger, 2015-08-13 11:51:52]

lgtm

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.mm (right):

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.mm:194: BOOL
md5_changed = ![md5 isEqualToData:last_pasteboard_entry_md5_];
On 2015/08/13 11:42:21, droger wrote:
> What happens if there is a collision? Is this a privacy issue?

Resolved by offline discussion: hash collisions are not a privacy issue and
covered by the design.

[Olivier, 2015-08-13 12:01:58]

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.h (right):

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.h:44: 
On 2015/08/13 11:42:21, droger wrote:
> Remove blank line.

Done.

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.mm (right):

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.mm:187: bool
not_rebooted = uptime > GetClipboardContentAge();
On 2015/08/13 11:42:21, droger wrote:
> Optional: should we early return here if (not_rebooted &&
change_count_changed)?

Done.

https://codereview.chromium.org/1288733002/diff/90001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.mm:187: bool
not_rebooted = uptime > GetClipboardContentAge();
On 2015/08/13 11:42:21, droger wrote:
> Optional: should we early return here if (not_rebooted &&
change_count_changed)?

Done.

[Olivier, 2015-08-13 12:02:05]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2015-08-13 12:02:05]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1288733002/#ps130001
(title: "moved comment")

[commit-bot: I haz the power, 2015-08-13 12:02:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288733002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288733002/130001

[jif-google, 2015-08-13 12:04:58]

jif@google.com changed reviewers:
+ jif@google.com

[jif-google, 2015-08-13 12:04:58]

lgtm

[commit-bot: I haz the power, 2015-08-13 12:10:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 12:10:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jif, 2015-08-13 12:13:32]

lgtm

[Olivier, 2015-08-13 12:13:57]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2015-08-13 12:14:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288733002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288733002/130001

[commit-bot: I haz the power, 2015-08-13 13:44:19]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2015-08-13 13:45:02]

Patchset 8 (id:??) landed as
https://crrev.com/80ac2af9f7a302e7a3e3d71a15fd070838f4ef2d
Cr-Commit-Position: refs/heads/master@{#343189}