Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288723005: [heap] Fix compilation of LargeObjectSpace on Windows. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer, Nico
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/heap/spaces.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
lgtm, this has a good chance of working I think.
5 years, 4 months ago (2015-08-19 17:34:23 UTC) #2
Michael Starzinger
5 years, 4 months ago (2015-08-19 17:34:37 UTC) #4
titzer
lgtm
5 years, 4 months ago (2015-08-19 17:35:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288723005/1
5 years, 4 months ago (2015-08-19 17:37:24 UTC) #7
hans
On 2015/08/19 17:34:23, Nico wrote: > lgtm, this has a good chance of working I ...
5 years, 4 months ago (2015-08-19 17:39:31 UTC) #8
Michael Starzinger
5 years, 4 months ago (2015-08-19 17:39:37 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
95694f00a761bc088a1e4f54183561704289ec11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698