Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1288693003: Fix scroll-restoration-push-replace.html test to support scrollTopLeftInterop mode (Closed)

Created:
5 years, 4 months ago by Rick Byers
Modified:
5 years, 4 months ago
Reviewers:
majidvp
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix scroll-restoration-push-replace.html test to support scrollTopLeftInterop mode BUG=157855 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200474

Patch Set 1 #

Patch Set 2 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/fast/history/scroll-restoration/scroll-restoration-push-replace.html View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Rick Byers
Majid PTAL. I'm about to flip scrollTopLeftInterop to experimental: https://codereview.chromium.org/1216953003/ (but want this fix in ...
5 years, 4 months ago (2015-08-13 02:02:49 UTC) #2
blink-reviews
Lgtm. It might however be easier to use window.scroll{X, Y} instead to avoid any dependency ...
5 years, 4 months ago (2015-08-13 02:11:03 UTC) #3
Rick Byers
Yeah document.scrollingElement.scrollTop is synonymous with window.scrollY so it doesn't make any difference either way... On ...
5 years, 4 months ago (2015-08-13 03:58:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288693003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288693003/20001
5 years, 4 months ago (2015-08-13 03:58:51 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-13 03:58:52 UTC) #8
majidvp
On 2015/08/13 03:58:52, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 4 months ago (2015-08-13 11:12:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288693003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288693003/20001
5 years, 4 months ago (2015-08-13 11:12:26 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 11:19:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200474

Powered by Google App Engine
This is Rietveld 408576698