Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288683004: Add support for non-mappable vert buffers to tessellating path renderer. (Closed)

Created:
5 years, 4 months ago by Stephen White
Modified:
5 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add support for non-mappable vert buffers to tessellating path renderer. Use malloc-ed memory and the updateData() call instead. BUG=skia:4215 Committed: https://skia.googlesource.com/skia/+/f39c9b2ccfc47338dda86aa897219e53574eea9f

Patch Set 1 #

Patch Set 2 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M src/gpu/GrTessellatingPathRenderer.cpp View 1 3 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 4 months ago (2015-08-18 18:01:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288683004/1
5 years, 4 months ago (2015-08-18 18:01:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2760) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on ...
5 years, 4 months ago (2015-08-18 18:02:29 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288683004/20001
5 years, 4 months ago (2015-08-18 18:04:30 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 18:10:45 UTC) #10
bsalomon
On 2015/08/18 18:04:30, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 4 months ago (2015-08-18 18:10:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288683004/20001
5 years, 4 months ago (2015-08-18 18:46:06 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 18:46:34 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f39c9b2ccfc47338dda86aa897219e53574eea9f

Powered by Google App Engine
This is Rietveld 408576698