Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1288653002: Service Worker: Change last update check location and HTTP cache bypass rule (1/2) (Closed)

Created:
5 years, 4 months ago by jungkees
Modified:
5 years, 2 months ago
CC:
blink-reviews, jsbell, tzik, serviceworker-reviews, dglazkov+blink, kinuko+serviceworker, horo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Change last update check location and HTTP cache bypass rule (1/2) As per the last f2f and the follow-up discussion, the registration's last update check time should be updated only when the script load request actually accessed network and received response without a network error. The time stamp should be updated regardless of whether the installation of the fetched resource succeeds or fails. This patch involves the following behavior changes: 1. Before: The last update check time was not updated when the installation of the fetched resouce fails. After: The last update check time is updated regardless of the result of the installation. 2. Before: registration.update() always bypassed HTTP cache. After: registration.update() no longer forces bypassing the HTTP cache but bypasses it only when 24 hours have passed since the last update check, as per spec. Spec: https://github.com/slightlyoff/ServiceWorker/commit/569863f3acd0f5d79beab9d8c63210b8286ee507 Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/514#issuecomment-135641718 Companion CL (Chromium): https://codereview.chromium.org/1283273002/ BUG=520068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/update-worker.php View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jungkees
PTAL.
5 years, 4 months ago (2015-08-12 16:26:27 UTC) #2
zino
peer review looks good to me
5 years, 4 months ago (2015-08-17 11:38:27 UTC) #3
jungkees
It has been reviewed from the spec perspective too: https://github.com/slightlyoff/ServiceWorker/issues/514#issuecomment-130664373. OWNERs, PTAL.
5 years, 4 months ago (2015-08-17 12:00:12 UTC) #5
nhiroki
lgtm
5 years, 4 months ago (2015-08-19 07:10:23 UTC) #6
falken
This looks good, but the "landing plan" is a bit overkill for this set of ...
5 years, 3 months ago (2015-09-10 02:09:39 UTC) #7
jungkees
I updated the CL description with the behavior changes and removed the landing plan part ...
5 years, 3 months ago (2015-09-10 15:01:01 UTC) #8
jungkees
5 years, 2 months ago (2015-10-06 02:04:55 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698