Issue 128863002: Hides auxiliary_text when candidates are hidden.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128863002: Hides auxiliary_text when candidates are hidden. (Closed)

Created:
6 years, 11 months ago by Jun Mukai

Modified:
6 years, 11 months ago

Reviewers:
hsumita, Hiro Komatsu

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hides auxiliary_text when candidates are hidden. Their visibility was controlled separately but r242610 changed this. This is intentionally false instead of is_auxiliary_text_visible() of candidate_window_ because that field is not updated at that point. BUG=332275 R=hsumita@chromium.org, komatsu@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243866

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/chromeos/input_method/candidate_window_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/128863002/1

6 years, 11 months ago (2014-01-09 02:26:04 UTC) #4

Message was sent while issue was closed.

Change committed as 243866

Expand Messages | Collapse Messages