Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1288623005: Make cssFloat an enumerable property of CSSStyleDeclaration (Closed)

Created:
5 years, 4 months ago by nainar
Modified:
5 years, 4 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, Inactive, dglazkov+blink, rwlbuis, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make cssFloat an enumerable property of CSSStyleDeclaration cssFloat does not show up as an enumerated property of CSSStyleDeclaration even though it does evaluate to a value. FF and IE both treat cssFloat as an enumerable property of CSSStyleDeclaration BUG=492999 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200965

Patch Set 1 #

Patch Set 2 : Make cssFloat an enumerable property of CSSStyleDeclaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
A LayoutTests/cssom/cssfloat-cssom.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nainar1
5 years, 4 months ago (2015-08-20 01:42:19 UTC) #2
Timothy Loh
On 2015/08/20 01:42:19, nainar wrote: Is this just a copy of https://codereview.chromium.org/1113013002/? Same comment as ...
5 years, 4 months ago (2015-08-20 02:05:59 UTC) #3
nainar1
Fixed the patch according to your suggestions. Take a look please? Thanks!
5 years, 4 months ago (2015-08-21 00:47:54 UTC) #4
Timothy Loh
On 2015/08/21 00:47:54, nainar wrote: > Fixed the patch according to your suggestions. Take a ...
5 years, 4 months ago (2015-08-21 02:50:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288623005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288623005/20001
5 years, 4 months ago (2015-08-21 02:56:24 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 05:34:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200965

Powered by Google App Engine
This is Rietveld 408576698