Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1288623003: [runtime] Remove useless %_IsUndetectableObject intrinsic. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev, rossberg, adamk, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove useless %_IsUndetectableObject intrinsic. Instead of using a sequence if (something == null && !IS_UNDETECTABLE(something))) { ... } which will be true if something is either null or undefined, it is way simpler and way more efficient to just write if (something === null || something === (void 0)) { ... } instead, which allows the compiler(s) to generate pretty decent code without any need to resort to type feedback from a CompareNil IC. R=yangguo@chromium.org Committed: https://crrev.com/88f90680fd7357d1b561594b9e8592fbdc474946 Cr-Commit-Position: refs/heads/master@{#30135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -220 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/macros.py View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/v8natives.js View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-12 13:12:44 UTC) #1
Benedikt Meurer
Hey Yang, There's moar awesomeness w/ undetectable. Please take a look. Thanks, Benedikt Adam, Andreas, ...
5 years, 4 months ago (2015-08-12 13:13:39 UTC) #2
Yang
On 2015/08/12 13:13:39, Benedikt Meurer wrote: > Hey Yang, > > There's moar awesomeness w/ ...
5 years, 4 months ago (2015-08-12 13:15:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288623003/1
5 years, 4 months ago (2015-08-12 13:18:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 13:44:13 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 13:44:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88f90680fd7357d1b561594b9e8592fbdc474946
Cr-Commit-Position: refs/heads/master@{#30135}

Powered by Google App Engine
This is Rietveld 408576698