Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1288613004: Merge updatePostLifecycleData into updateAllLifecyclePhasesInternal. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
Reviewers:
pdr., ojan
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Merge updatePostLifecycleData into updateAllLifecyclePhasesInternal. Having this in a separate method just encourages duplicate checks like the NULL check here, and the local root frame check which are both not needed. Move this into the only caller so the sequence of steps when updating the lifecycle phases is more clear. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 2 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288613004/1
5 years, 4 months ago (2015-08-14 19:32:26 UTC) #2
esprehn
5 years, 4 months ago (2015-08-14 21:11:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93514)
5 years, 4 months ago (2015-08-14 21:39:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288613004/1
5 years, 4 months ago (2015-08-14 23:46:55 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-14 23:46:56 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288613004/1
5 years, 4 months ago (2015-08-14 23:48:35 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-15 00:44:09 UTC) #14
ojan
lgtm
5 years, 4 months ago (2015-08-15 00:48:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288613004/1
5 years, 4 months ago (2015-08-15 00:49:01 UTC) #17
pdr.
On 2015/08/15 at 00:49:01, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years, 4 months ago (2015-08-15 00:49:48 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 00:52:56 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200584

Powered by Google App Engine
This is Rietveld 408576698