Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: net/socket/transport_client_socket_unittest.cc

Issue 12886034: Remove experimental code to pick the "warmest" socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync, fix conflict Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/transport_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_http_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/transport_client_socket_unittest.cc
===================================================================
--- net/socket/transport_client_socket_unittest.cc (revision 191149)
+++ net/socket/transport_client_socket_unittest.cc (working copy)
@@ -290,8 +290,6 @@
rv = sock_->Read(buf, 4096, callback.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
- EXPECT_EQ(static_cast<int64>(std::string(kServerReply).size()),
- sock_->NumBytesRead());
CloseServerSocket();
EXPECT_EQ(0, callback.WaitForResult());
}
@@ -324,8 +322,6 @@
// then close the server socket, and note the close.
rv = sock_->Read(buf, 1, callback.callback());
- EXPECT_EQ(static_cast<int64>(std::string(kServerReply).size()),
- sock_->NumBytesRead());
ASSERT_EQ(ERR_IO_PENDING, rv);
CloseServerSocket();
EXPECT_EQ(0, callback.WaitForResult());
@@ -346,12 +342,9 @@
scoped_refptr<IOBuffer> buf(new IOBuffer(16));
rv = sock_->Read(buf, 16, callback.callback());
EXPECT_TRUE(rv >= 0 || rv == ERR_IO_PENDING);
- EXPECT_EQ(0, sock_->NumBytesRead());
- if (rv == ERR_IO_PENDING) {
+ if (rv == ERR_IO_PENDING)
rv = callback.WaitForResult();
- EXPECT_EQ(16, sock_->NumBytesRead());
- }
EXPECT_NE(0, rv);
}
« no previous file with comments | « net/socket/transport_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_http_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698