net/socket/transport_client_socket_unittest.cc - Issue 12886034: Remove experimental code to pick the "warmest" socket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/transport_client_socket_unittest.cc

Issue 12886034: Remove experimental code to pick the "warmest" socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Don't add missing include (Shouldn't be done in this CL) Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/transport_client_socket_unittest.cc

===================================================================

--- net/socket/transport_client_socket_unittest.cc (revision 190096)

+++ net/socket/transport_client_socket_unittest.cc (working copy)

@@ -290,8 +290,6 @@

rv = sock_->Read(buf, 4096, callback.callback());

ASSERT_EQ(ERR_IO_PENDING, rv);

- EXPECT_EQ(static_cast<int64>(std::string(kServerReply).size()),

- sock_->NumBytesRead());

CloseServerSocket();

EXPECT_EQ(0, callback.WaitForResult());

}

@@ -324,8 +322,6 @@

// then close the server socket, and note the close.

rv = sock_->Read(buf, 1, callback.callback());

- EXPECT_EQ(static_cast<int64>(std::string(kServerReply).size()),

- sock_->NumBytesRead());

ASSERT_EQ(ERR_IO_PENDING, rv);

CloseServerSocket();

EXPECT_EQ(0, callback.WaitForResult());

@@ -346,12 +342,9 @@

scoped_refptr<IOBuffer> buf(new IOBuffer(16));

rv = sock_->Read(buf, 16, callback.callback());

EXPECT_TRUE(rv >= 0 || rv == ERR_IO_PENDING);

- EXPECT_EQ(0, sock_->NumBytesRead());

- if (rv == ERR_IO_PENDING) {

+ if (rv == ERR_IO_PENDING)

rv = callback.WaitForResult();

- EXPECT_EQ(16, sock_->NumBytesRead());

- }

EXPECT_NE(0, rv);

}