content/browser/android/background_sync_launcher_android.cc - Issue 1288593003: [BackgroundSync] Move read and write of shared preferences to an AsyncTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/background_sync_launcher_android.cc

Issue 1288593003: [BackgroundSync] Move read and write of shared preferences to an AsyncTask (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/BackgroundSyncLauncher.java » ('j') | content/public/android/java/src/org/chromium/content/browser/BackgroundSyncLauncher.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/background_sync_launcher_android.cc

diff --git a/content/browser/android/background_sync_launcher_android.cc b/content/browser/android/background_sync_launcher_android.cc

index 78110c14f6428b08b9ca0ed3d22bb20418bfa00b..693817baa8a8174bad383aac37131c9531a0603e 100644

--- a/content/browser/android/background_sync_launcher_android.cc

+++ b/content/browser/android/background_sync_launcher_android.cc

@@ -46,7 +46,8 @@ void BackgroundSyncLauncherAndroid::LaunchBrowserWhenNextOnlineImpl(

if (was_launching != now_launching) {

JNIEnv* env = base::android::AttachCurrentThread();

Java_BackgroundSyncLauncher_setLaunchWhenNextOnline(

- env, java_launcher_.obj(), now_launching);

+ env, java_launcher_.obj(), base::android::GetApplicationContext(),

jdduke (slow) 2015/08/19 17:45:14 Hmm, is this code executed on WebView? I don't thi

jkarlin 2015/08/19 18:23:49 I'm not sure, so I've created a bug. Either way th

+ now_launching);

}