Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: pkg/compiler/lib/src/dump_info.dart

Issue 1288593002: dart2js: add function coverage tracking in dart2js output, dumpinfo, and (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/info/info.dart » ('j') | pkg/compiler/tool/coverage_log_server.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dump_info.dart
diff --git a/pkg/compiler/lib/src/dump_info.dart b/pkg/compiler/lib/src/dump_info.dart
index 898337ba3a1143f0631d38135839300e75ad1227..5ea735862a3e3211362e0c403351fd27d5d412eb 100644
--- a/pkg/compiler/lib/src/dump_info.dart
+++ b/pkg/compiler/lib/src/dump_info.dart
@@ -128,6 +128,9 @@ class ElementInfoCollector extends BaseElementVisitor<Info, dynamic> {
FieldInfo info = new FieldInfo(
name: element.name,
+ // We use element.hashCode because it is globally unique and it is
+ // available while we are doing codegen.
+ coverageId: '${element.hashCode}',
type: '${element.type}',
inferredType: '$inferredType',
size: size,
@@ -268,6 +271,9 @@ class ElementInfoCollector extends BaseElementVisitor<Info, dynamic> {
FunctionInfo info = new FunctionInfo(
name: name,
+ // We use element.hashCode because it is globally unique and it is
+ // available while we are doing codegen.
+ coverageId: '${element.hashCode}',
modifiers: modifiers,
size: size,
returnType: returnType,
« no previous file with comments | « no previous file | pkg/compiler/lib/src/info/info.dart » ('j') | pkg/compiler/tool/coverage_log_server.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698