Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288553009: Fetch/Request/Redirect: Disable flaky cases (Closed)

Created:
5 years, 4 months ago by jsbell
Modified:
5 years, 4 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fetch/Request/Redirect: Disable flaky cases Test relied on a timeout to detect iframe load failures, but on slow bots (debug, msan, etc) the timeout might be hit. Remove the timeout and disable the test cases that rely on it for now. Also tweak the test structure slightly to use promise_test to ease debugging. BUG=522587 TBR=horo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-request-redirect.html View 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288553009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288553009/1
5 years, 4 months ago (2015-08-19 20:35:14 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 21:13:07 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200847

Powered by Google App Engine
This is Rietveld 408576698