Skipping mouseenter/over/out/leave on deleted nodes.

Skipping mouseenter/over/out/leave on deleted nodes.

Both IE and FF skip firing of mouse transition events at deleted nodes,
with only IE doing it in a perfect manner by maintining the pairing of
entry/exit events. A crack in our code had been causing firing of these
events at a node after the node got deleted. This CL fixes the bug by
making chromium behave similar to FF. The perfect solution seems
non-trivial.

BUG=515921
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200656

[mustaq, 2015-08-11 17:55:34]

mustaq@chromium.org changed reviewers:
+ rbyers@chromium.org

[mustaq, 2015-08-11 17:55:34]

ptal

[Rick Byers, 2015-08-12 22:16:58]

LGTM with nit

https://codereview.chromium.org/1288483003/diff/1/LayoutTests/fast/events/mou...
File LayoutTests/fast/events/mouse-events-on-node-deletion-expected.txt (right):

https://codereview.chromium.org/1288483003/diff/1/LayoutTests/fast/events/mou...
LayoutTests/fast/events/mouse-events-on-node-deletion-expected.txt:13: outer
received mouseenter
Nit: It's this extra mouseenter that's really still a bug, right?  Maybe leave a
TODO in the test describing the way in which it's still non-perfect and
referencing the bug.

[mustaq, 2015-08-13 14:36:32]

https://codereview.chromium.org/1288483003/diff/1/LayoutTests/fast/events/mou...
File LayoutTests/fast/events/mouse-events-on-node-deletion-expected.txt (right):

https://codereview.chromium.org/1288483003/diff/1/LayoutTests/fast/events/mou...
LayoutTests/fast/events/mouse-events-on-node-deletion-expected.txt:13: outer
received mouseenter
On 2015/08/12 22:16:58, Rick Byers wrote:
> Nit: It's this extra mouseenter that's really still a bug, right?  Maybe leave
a
> TODO in the test describing the way in which it's still non-perfect and
> referencing the bug.

Done.

[mustaq, 2015-08-13 14:43:09]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2015-08-13 14:43:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1288483003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-08-13 14:43:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288483003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288483003/20001

[Rick Byers, 2015-08-13 14:43:26]

Thanks, still LGTM

[commit-bot: I haz the power, 2015-08-13 15:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 15:29:45]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/66099)

[dtapuska, 2015-08-14 17:20:09]

dtapuska@chromium.org changed reviewers:
+ dtapuska@chromium.org

[dtapuska, 2015-08-14 17:20:09]

https://codereview.chromium.org/1288483003/diff/20001/Source/core/input/Event...
File Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/1288483003/diff/20001/Source/core/input/Event...
Source/core/input/EventHandler.cpp:1529: if (exitedNode &&
exitedNode->inDocument())
Can we just make an anonymous scope function to check this?

bool isNodeInDocument(Node* n) {
   return n && n->inDocument();
}

instead of repeating it a few times?

[mustaq, 2015-08-14 21:00:16]

https://codereview.chromium.org/1288483003/diff/20001/Source/core/input/Event...
File Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/1288483003/diff/20001/Source/core/input/Event...
Source/core/input/EventHandler.cpp:1529: if (exitedNode &&
exitedNode->inDocument())
On 2015/08/14 17:20:09, dtapuska wrote:
> Can we just make an anonymous scope function to check this?
> 
> bool isNodeInDocument(Node* n) {
>    return n && n->inDocument();
> }
> 
> instead of repeating it a few times?

Done.

[mustaq, 2015-08-14 21:09:48]

On 2015/08/14 21:00:16, mustaq wrote:
>
https://codereview.chromium.org/1288483003/diff/20001/Source/core/input/Event...
> File Source/core/input/EventHandler.cpp (right):
> 
>
https://codereview.chromium.org/1288483003/diff/20001/Source/core/input/Event...
> Source/core/input/EventHandler.cpp:1529: if (exitedNode &&
> exitedNode->inDocument())
> On 2015/08/14 17:20:09, dtapuska wrote:
> > Can we just make an anonymous scope function to check this?
> > 
> > bool isNodeInDocument(Node* n) {
> >    return n && n->inDocument();
> > }
> > 
> > instead of repeating it a few times?
> 
> Done.

In my last patch, I also removed the "expected result" blocks from the test
htmls.

[mustaq, 2015-08-14 21:24:23]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2015-08-14 21:24:23]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1288483003/#ps40001
(title: "Fixed bad test expectations")

[commit-bot: I haz the power, 2015-08-14 21:24:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288483003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288483003/40001

[commit-bot: I haz the power, 2015-08-14 22:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-14 22:26:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mustaq, 2015-08-17 17:07:35]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2015-08-17 17:07:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1288483003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-08-17 17:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288483003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288483003/60001

[commit-bot: I haz the power, 2015-08-17 18:25:23]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200656