Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1288393002: Add proguard to third_party library. (Closed)

Created:
5 years, 4 months ago by Xi Han
Modified:
5 years, 3 months ago
Reviewers:
open-source-third-party-reviews, Yaron, brettw
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add proguard to third_party library. Chrome use proguard library from Android's sdk, rather than from gradle which keeps proguard updated. Therefore, the version of proguard is way lower than other apps which use gradle. To keep proguard updated, we want to move proguard to third_party library and manage its update by Chrome. This is the first part of a series: - https://codereview.chromium.org/1288393002/ - https://codereview.chromium.org/1292883002/ BUG=505932 Committed: https://crrev.com/ef70913e5ffb4f5cf0fe70a3a36d487dc3b23a1a Cr-Commit-Position: refs/heads/master@{#345371}

Patch Set 1 : #

Patch Set 2 : Back to Proguard 4.7. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A + third_party/proguard/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/proguard/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/proguard/README.chromium View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/proguard/lib/proguard.jar View 1 Binary file 0 comments Download

Messages

Total messages: 18 (7 generated)
Xi Han
Can you take a look first? Thanks:)
5 years, 4 months ago (2015-08-13 15:53:29 UTC) #2
Xi Han
Remove all the unnecessary files and only keep the .jar file. PTAL, thanks.
5 years, 4 months ago (2015-08-13 18:14:25 UTC) #4
Yaron
This lgtm I take it you'll have a separate CL to switch usage to it?
5 years, 4 months ago (2015-08-13 18:36:01 UTC) #5
Xi Han
Yes, will submit a follow up CL to switch usage of proguard.jar. I plan to ...
5 years, 4 months ago (2015-08-13 19:36:54 UTC) #6
Xi Han
The Proguard.jar is already in third_party/android_tools/sdk/tools/proguard/lib, now we want to move it to third_party/proguard/lib directly. ...
5 years, 4 months ago (2015-08-24 20:40:21 UTC) #8
Xi Han
+open-source-third-party-reviews@google.com: The Proguard.jar is already in third_party/android_tools/sdk/tools/proguard/lib, now we want to move it to third_party/proguard/lib ...
5 years, 3 months ago (2015-08-25 16:55:20 UTC) #11
chromium-reviews
Lgtm for ostpr On Tue, Aug 25, 2015, 9:55 AM <hanxi@chromium.org> wrote: > +open-source-third-party-reviews@google.com: > ...
5 years, 3 months ago (2015-08-25 17:14:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288393002/40001
5 years, 3 months ago (2015-08-25 17:32:43 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-08-25 17:43:27 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ef70913e5ffb4f5cf0fe70a3a36d487dc3b23a1a Cr-Commit-Position: refs/heads/master@{#345371}
5 years, 3 months ago (2015-08-25 17:44:44 UTC) #17
brettw
5 years, 3 months ago (2015-08-25 17:51:41 UTC) #18
Message was sent while issue was closed.
This seems fine with eng-review.

On Mon, Aug 24, 2015 at 1:40 PM, <hanxi@chromium.org> wrote:

> The Proguard.jar is already in
> third_party/android_tools/sdk/tools/proguard/lib,
> now we want to move it to third_party/proguard/lib directly. Therefore,
> Chrome
> can keep it updated. Please take a look, thanks.
>
> https://codereview.chromium.org/1288393002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698