[BlobAsync] Patch 2: Common Constants

content/common/blob_storage/blob_storage_messages.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Multiply-included message file, hence no include guard.
+
+#include <vector>
+
+#include "base/memory/shared_memory.h"
+#include "content/common/content_export.h"
+#include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_message_utils.h"
+#include "ipc/ipc_param_traits.h"
+#include "ipc/ipc_platform_file.h"
+#include "storage/common/blob_storage/blob_item_bytes_request.h"
+#include "storage/common/blob_storage/blob_item_bytes_response.h"
+#include "storage/common/blob_storage/blob_storage_constants.h"
+#include "storage/common/data_element.h"
+
+#undef IPC_MESSAGE_EXPORT
+#define IPC_MESSAGE_EXPORT CONTENT_EXPORT
+#define IPC_MESSAGE_START BlobMsgStart

[michaeln, 2015/08/18 03:04:41]

BlobMsgStart is in use in webblob_messages.h. I think having it here too can
cause msg id collisions.

We could keep all of the blob related messages defined in one place to keep it
simple. The old ones can be named BlahMsg_OLD, or the new ones _NEW for the time
in which they overlap in the sources?

[dmurph, 2015/09/15 01:12:12]

Yes, I actually move all of the blob message over here and delete that class in
the final patch.  It did cause collisions.  Since this patch won't have this guy
be included at all, I though it was find to keep it like this.

+
+IPC_ENUM_TRAITS_MAX_VALUE(storage::IPCBlobItemRequestStrategy,
+                          storage::IPCBlobItemRequestStrategy::LAST)
+IPC_ENUM_TRAITS_MAX_VALUE(storage::IPCBlobCreationCancelCode,
+                          storage::IPCBlobCreationCancelCode::LAST)
+
+IPC_STRUCT_TRAITS_BEGIN(storage::BlobItemBytesRequest)
+  IPC_STRUCT_TRAITS_MEMBER(request_number)
+  IPC_STRUCT_TRAITS_MEMBER(transport_strategy)
+  IPC_STRUCT_TRAITS_MEMBER(renderer_item_index)
+  IPC_STRUCT_TRAITS_MEMBER(renderer_item_offset)
+  IPC_STRUCT_TRAITS_MEMBER(size)
+  IPC_STRUCT_TRAITS_MEMBER(handle_index)
+  IPC_STRUCT_TRAITS_MEMBER(handle_offset)
+IPC_STRUCT_TRAITS_END()
+
+IPC_STRUCT_TRAITS_BEGIN(storage::BlobItemBytesResponse)
+  IPC_STRUCT_TRAITS_MEMBER(request_number)
+  IPC_STRUCT_TRAITS_MEMBER(inline_data)
+IPC_STRUCT_TRAITS_END()
+
+// This message is to tell the browser that we will be building a blob.
+IPC_MESSAGE_CONTROL1(BlobStorageMsg_RegisterBlobUUID, std::string /* uuid */);
+
+// The DataElements are used to:
+// * describe & transport non-memory resources (blobs, files, etc)
+// * describe the size of memory items
+// * 'shortcut' transport the memory up to the IPC limit so the browser can use
+//   it if it's not currently full.
+// See https://bit.ly/BlobStorageRefactor
+IPC_MESSAGE_CONTROL3(BlobStorageMsg_StartBuildingBlob,
+                     std::string /* uuid */,
+                     std::string /* type */,
+                     std::vector<storage::DataElement> /* item_descriptions */);
+
+IPC_MESSAGE_CONTROL4(BlobStorageMsg_RequestMemoryItem,
+                     std::string,                                 // uuid
+                     std::vector<storage::BlobItemBytesRequest>,  // requests
+                     std::vector<base::SharedMemoryHandle>,  // memory_handles
+                     std::vector<IPC::PlatformFileForTransit>);  // file_handles
+
+IPC_MESSAGE_CONTROL2(BlobStorageMsg_MemoryItemResponse,
+                     std::string,                                   // uuid
+                     std::vector<storage::BlobItemBytesResponse>);  // responses
+
+IPC_MESSAGE_CONTROL2(BlobStorageMsg_CancelBuildingBlob,
+                     std::string,                          // uuid
+                     storage::IPCBlobCreationCancelCode);  // code
+
+IPC_MESSAGE_CONTROL1(BlobStorageMsg_DoneBuildingBlob, std::string);  // uuid