Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288323006: Remove willRequestResource callback, it is unused outside of tests. (Closed)

Created:
5 years, 4 months ago by Nate Chapin
Modified:
5 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, Yoav Weiss, Nate Chapin, gavinp+loader_chromium.org, tyoshino+watch_chromium.org, kinuko+watch
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove willRequestResource callback, it is unused outside of tests. API in WebFrameClient will be removed after corresponding test harness logic is removed. BUG=523091 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200943

Patch Set 1 #

Patch Set 2 : Remove resource-request-callback.html from TestExpectations #

Patch Set 3 : Remove some experiments I accidentally included #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -131 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-innerhtml.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/loader/resource-request-callbacks.html View 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/fast/loader/resource-request-callbacks-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/fetch/FetchContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/FetchContext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nate Chapin
This callback was added back in 2012 and appears to have never been used. Time ...
5 years, 4 months ago (2015-08-20 20:37:37 UTC) #2
Mike West
On 2015/08/20 at 20:37:37, japhet wrote: > This callback was added back in 2012 and ...
5 years, 4 months ago (2015-08-20 21:12:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288323006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288323006/1
5 years, 4 months ago (2015-08-20 21:18:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90889)
5 years, 4 months ago (2015-08-20 21:28:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288323006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288323006/40001
5 years, 4 months ago (2015-08-20 21:50:09 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 00:27:06 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200943

Powered by Google App Engine
This is Rietveld 408576698