Issue 1288323003: Fix format specifier in proc maps to support 32-bit architectures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1288323003: Fix format specifier in proc maps to support 32-bit architectures. (Closed)

Created:
5 years, 4 months ago by liuandrew

Modified:
5 years, 4 months ago

Reviewers:
ahonig, ivanpe

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Fix format specifier in proc maps to support 32-bit architectures. R=ivanpe@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1486

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/google_breakpad/processor/proc_maps_linux.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/processor/proc_maps_linux.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

liuandrew

Passes on both 32 bit and 64 bit. No compiler warnings. I used SCNx64 and ...

5 years, 4 months ago (2015-08-13 19:31:07 UTC) #2

ivanpe

On 2015/08/13 19:31:07, liuandrew wrote: > Passes on both 32 bit and 64 bit. No ...

5 years, 4 months ago (2015-08-13 20:07:56 UTC) #3

liuandrew

5 years, 4 months ago (2015-08-13 20:13:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r1486 (presubmit successful).