Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1288313002: [microdump] Fix hw architecture indication in build fingerprint line (Closed)

Created:
5 years, 4 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 4 months ago
Reviewers:
mmandlis, Torne
CC:
google-breakpad-dev_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[microdump] Fix hw architecture indication in build fingerprint line r1456 introduced the possibility to customize the OS-line of the microdump, enabling to replace, in the case of android, the generic uname() info with the Android build fingerprint. While doing that, it mistakenly removed the HW architecture indication from the format. See crbug.com/520075 for more details. BUG=chromium:520075 R=mmandlis@chromium.org, torne@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1489

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -15 lines) Patch
M src/client/linux/microdump_writer/microdump_writer.cc View 2 chunks +16 lines, -12 lines 0 comments Download
M src/client/linux/microdump_writer/microdump_writer_unittest.cc View 1 3 chunks +44 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Primiano Tucci (use gerrit)
5 years, 4 months ago (2015-08-13 09:15:35 UTC) #2
Torne
lgtm
5 years, 4 months ago (2015-08-13 09:34:22 UTC) #3
mmandlis
https://codereview.chromium.org/1288313002/diff/1/src/client/linux/microdump_writer/microdump_writer.cc File src/client/linux/microdump_writer/microdump_writer.cc (right): https://codereview.chromium.org/1288313002/diff/1/src/client/linux/microdump_writer/microdump_writer.cc#newcode210 src/client/linux/microdump_writer/microdump_writer.cc:210: LogAppend("no build fingerprint available"); could you, please, add tests ...
5 years, 4 months ago (2015-08-13 16:31:24 UTC) #4
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1288313002/diff/1/src/client/linux/microdump_writer/microdump_writer.cc File src/client/linux/microdump_writer/microdump_writer.cc (right): https://codereview.chromium.org/1288313002/diff/1/src/client/linux/microdump_writer/microdump_writer.cc#newcode210 src/client/linux/microdump_writer/microdump_writer.cc:210: LogAppend("no build fingerprint available"); On 2015/08/13 16:31:24, mmandlis wrote: ...
5 years, 4 months ago (2015-08-14 11:49:32 UTC) #8
Primiano Tucci (use gerrit)
Maria, can you take a second look to this plz (added tests)?
5 years, 4 months ago (2015-08-14 16:28:44 UTC) #9
mmandlis
lgtm Thanks!
5 years, 4 months ago (2015-08-14 16:45:06 UTC) #10
Primiano Tucci (use gerrit)
5 years, 4 months ago (2015-08-17 08:02:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as 1489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698