Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: Source/modules/webgl/WebGLRenderingContextBase.h

Issue 1288303002: WebGL 2: add types into glReadPixels (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: nits Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webgl/WebGLRenderingContextBase.h
diff --git a/Source/modules/webgl/WebGLRenderingContextBase.h b/Source/modules/webgl/WebGLRenderingContextBase.h
index 562bdca9c984ed0e1649eae46846724c8068580c..0eec8981b32b28aa214d68550c47326136cbc460 100644
--- a/Source/modules/webgl/WebGLRenderingContextBase.h
+++ b/Source/modules/webgl/WebGLRenderingContextBase.h
@@ -829,6 +829,9 @@ protected:
// Generates INVALID_ENUM and returns false if parameters are invalid.
virtual bool validateReadPixelsFormatAndType(GLenum format, GLenum type);
+ // Helper function to get expected ArrayBuffer view type for readPixels.
+ virtual DOMArrayBufferView::ViewType readPixelsExpectedArrayBufferViewType(GLenum type);
+
// Helper function to check format/type combination for readPixels.
// Generates INVALID_OPERATION and returns false if the combination is unsupported.
bool validateReadPixelsFormatTypeCombination(GLenum format, GLenum type, GLenum readBufferInternalFormat, GLenum readBufferType);
« no previous file with comments | « Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698