Source/modules/webgl/WebGL2RenderingContextBase.h - Issue 1288303002: WebGL 2: add types into glReadPixels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 1288303002: WebGL 2: add types into glReadPixels (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: To make the code snippet clearer, override the part of getting ArrayBuffer ViewType in readPixels f… Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webgl/WebGL2RenderingContextBase.h

diff --git a/Source/modules/webgl/WebGL2RenderingContextBase.h b/Source/modules/webgl/WebGL2RenderingContextBase.h

index 834b344cf848d63bdfcee7b7b7f313b0481b6670..57ed56fdd52608438145e14f5c904e4ad176e96f 100644

--- a/Source/modules/webgl/WebGL2RenderingContextBase.h

+++ b/Source/modules/webgl/WebGL2RenderingContextBase.h

@@ -199,6 +199,7 @@ protected:

WebGLTexture* validateTextureBinding(const char* functionName, GLenum target, bool useSixEnumsForCubeMap) override;

bool validateFramebufferTarget(GLenum target) override;

bool validateReadPixelsFormatAndType(GLenum format, GLenum type) override;

+ DOMArrayBufferView::ViewType readPixelsExpectedArrayBufferViewType(GLenum type) override;

WebGLFramebuffer* getFramebufferBinding(GLenum target) override;

GLint getMaxTextureLevelForTarget(GLenum target) override;

void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internalformat, GLsizei width, GLsizei height, const char* functionName) override;

« no previous file with comments | « no previous file | Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')