Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 1288303002: WebGL 2: add types into glReadPixels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1288303002: WebGL 2: add types into glReadPixels (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index ac4d668041be05faea042a43cee8b63a71352934..55a0f13e9dd610dd643877287032e0c43be9f47c 100644

--- a/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -2115,9 +2115,11 @@ bool WebGL2RenderingContextBase::validateReadPixelsFormatAndType(GLenum format,

case GL_BYTE:

case GL_HALF_FLOAT:

case GL_FLOAT:

+ case GL_UNSIGNED_SHORT:

case GL_UNSIGNED_SHORT_5_6_5:

case GL_UNSIGNED_SHORT_4_4_4_4:

case GL_UNSIGNED_SHORT_5_5_5_1:

+ case GL_SHORT:

case GL_UNSIGNED_INT:

case GL_UNSIGNED_INT_2_10_10_10_REV:

case GL_UNSIGNED_INT_10F_11F_11F_REV: