Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 1288303002: WebGL 2: add types into glReadPixels (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: To make the code snippet clearer, override the part of getting ArrayBuffer ViewType in readPixels f… Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "modules/webgl/WebGLExtension.h" 8 #include "modules/webgl/WebGLExtension.h"
9 #include "modules/webgl/WebGLRenderingContextBase.h" 9 #include "modules/webgl/WebGLRenderingContextBase.h"
10 #include "wtf/PassRefPtr.h" 10 #include "wtf/PassRefPtr.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 void texSubImage3DImpl(GLenum, GLint, GLint, GLint, GLint, GLenum, GLenum, I mage*, WebGLImageConversion::ImageHtmlDomSource, bool, bool); 192 void texSubImage3DImpl(GLenum, GLint, GLint, GLint, GLint, GLenum, GLenum, I mage*, WebGLImageConversion::ImageHtmlDomSource, bool, bool);
193 193
194 /* WebGLRenderingContextBase overrides */ 194 /* WebGLRenderingContextBase overrides */
195 unsigned getMaxWebGLLocationLength() const override { return 1024; }; 195 unsigned getMaxWebGLLocationLength() const override { return 1024; };
196 bool validateCapability(const char* functionName, GLenum) override; 196 bool validateCapability(const char* functionName, GLenum) override;
197 bool validateBufferTarget(const char* functionName, GLenum target) override; 197 bool validateBufferTarget(const char* functionName, GLenum target) override;
198 bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, Web GLBuffer*) override; 198 bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, Web GLBuffer*) override;
199 WebGLTexture* validateTextureBinding(const char* functionName, GLenum target , bool useSixEnumsForCubeMap) override; 199 WebGLTexture* validateTextureBinding(const char* functionName, GLenum target , bool useSixEnumsForCubeMap) override;
200 bool validateFramebufferTarget(GLenum target) override; 200 bool validateFramebufferTarget(GLenum target) override;
201 bool validateReadPixelsFormatAndType(GLenum format, GLenum type) override; 201 bool validateReadPixelsFormatAndType(GLenum format, GLenum type) override;
202 DOMArrayBufferView::ViewType readPixelsExpectedArrayBufferViewType(GLenum ty pe) override;
202 WebGLFramebuffer* getFramebufferBinding(GLenum target) override; 203 WebGLFramebuffer* getFramebufferBinding(GLenum target) override;
203 GLint getMaxTextureLevelForTarget(GLenum target) override; 204 GLint getMaxTextureLevelForTarget(GLenum target) override;
204 void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internal format, GLsizei width, GLsizei height, const char* functionName) override; 205 void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internal format, GLsizei width, GLsizei height, const char* functionName) override;
205 GLenum boundFramebufferColorFormat() override; 206 GLenum boundFramebufferColorFormat() override;
206 207
207 WebGLBuffer* validateBufferDataTarget(const char* functionName, GLenum targe t) override; 208 WebGLBuffer* validateBufferDataTarget(const char* functionName, GLenum targe t) override;
208 209
209 void removeBoundBuffer(WebGLBuffer*) override; 210 void removeBoundBuffer(WebGLBuffer*) override;
210 211
211 RefPtrWillBeMember<WebGLFramebuffer> m_readFramebufferBinding; 212 RefPtrWillBeMember<WebGLFramebuffer> m_readFramebufferBinding;
(...skipping 13 matching lines...) Expand all
225 WillBeHeapVector<RefPtrWillBeMember<WebGLSampler>> m_samplerUnits; 226 WillBeHeapVector<RefPtrWillBeMember<WebGLSampler>> m_samplerUnits;
226 }; 227 };
227 228
228 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context, 229 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context,
229 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 230 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
230 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ; 231 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ;
231 232
232 } // namespace blink 233 } // namespace blink
233 234
234 #endif 235 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698