Source/modules/fetch/FetchHeaderList.h - Issue 1288263003: Normalize and update the header value checks to RFC 7230 for Fetch

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/fetch/FetchHeaderList.h

Issue 1288263003: Normalize and update the header value checks to RFC 7230 for Fetch Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef FetchHeaderList_h	5 #ifndef FetchHeaderList_h

6 #define FetchHeaderList_h	6 #define FetchHeaderList_h

7	7

8 #include "modules/ModulesExport.h"	8 #include "modules/ModulesExport.h"

9 #include "platform/heap/Handle.h"	9 #include "platform/heap/Handle.h"

10 #include "wtf/OwnPtr.h"	10 #include "wtf/OwnPtr.h"

(...skipping 25 matching lines...) Expand all Loading...
36 void getAll(const String&, Vector<String>&) const;	36 void getAll(const String&, Vector<String>&) const;

37 bool has(const String&) const;	37 bool has(const String&) const;

38 void clearList();	38 void clearList();

39	39

40 bool containsNonSimpleHeader() const;	40 bool containsNonSimpleHeader() const;

41	41

42 const Vector<OwnPtr<Header>>& list() const { return m_headerList; }	42 const Vector<OwnPtr<Header>>& list() const { return m_headerList; }

43 const Header& entry(size_t index) const { return *(m_headerList[index].get() ); }	43 const Header& entry(size_t index) const { return *(m_headerList[index].get() ); }

44	44

45 static bool isValidHeaderName(const String&);	45 static bool isValidHeaderName(const String&);

46 static bool isValidHeaderValue(const String&);	46 static bool isValidHeaderValue(const String&);
	yhirano 2015/09/09 04:41:50 Is this function used? Is this function used? shiva.jm 2015/09/10 10:10:26 not used removed. Show quoted text On 2015/09/09 04:41:50, yhirano wrote: > Is this function used? not used removed.
	47 static bool isValidFieldContentRFC7230(const String&);

47	48

48 DEFINE_INLINE_TRACE() { }	49 DEFINE_INLINE_TRACE() { }

49	50

50 private:	51 private:

51 FetchHeaderList();	52 FetchHeaderList();

52 Vector<OwnPtr<Header>> m_headerList;	53 Vector<OwnPtr<Header>> m_headerList;

53 };	54 };

54	55

55 } // namespace blink	56 } // namespace blink

56	57

57 #endif // FetchHeaderList_h	58 #endif // FetchHeaderList_h

OLD	NEW

« Source/core/fetch/FetchUtils.cpp ('K') | « Source/core/fetch/FetchUtils.cpp ('k') | Source/modules/fetch/FetchHeaderList.cpp » ('j') | Source/modules/fetch/FetchHeaderList.cpp » ('J')