Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1288263002: GN: app_list_unittests links on Mac. (Closed)

Created:
5 years, 4 months ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: app_list_unittests links on Mac. Tested on Mac with the following command lines: $ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' $ ninja -C out-gn/Release app_list_unittests BUG=431177 TEST=see above R=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/42aa017bfdf37b56605343897db81df7167f11a1 Cr-Commit-Position: refs/heads/master@{#343275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 4 months ago (2015-08-13 02:59:43 UTC) #1
Dirk Pranke
lgtm. Make sure you land this -- and any mac changes -- with CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
5 years, 4 months ago (2015-08-13 20:09:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288263002/1
5 years, 4 months ago (2015-08-13 21:07:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 21:12:45 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 21:13:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42aa017bfdf37b56605343897db81df7167f11a1
Cr-Commit-Position: refs/heads/master@{#343275}

Powered by Google App Engine
This is Rietveld 408576698