Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1288223004: msvs_emulation: Add support for StackReserveSize and StackCommitSize (Closed)

Created:
5 years, 4 months ago by Shezan Baig (Bloomberg)
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

msvs_emulation: Add support for StackReserveSize and StackCommitSize Note that StackCommitSize has no effect unless StackReserveSize is also set. This is consistent with how msvs works. BUG= R=scottmg@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/010fb9d696e7c79ffcbc4342efff3436cdc19f90

Patch Set 1 #

Patch Set 2 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -15 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 chunk +9 lines, -0 lines 0 comments Download
A test/win/gyptest-link-stacksize.py View 1 chunk +62 lines, -0 lines 0 comments Download
A + test/win/linker-flags/stacksize.gyp View 1 1 chunk +14 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Shezan Baig (Bloomberg)
5 years, 4 months ago (2015-08-13 08:30:48 UTC) #2
Shezan Baig (Bloomberg)
Hmm, I tried "git cl try" but the trybots show up grey
5 years, 4 months ago (2015-08-13 08:42:07 UTC) #3
Shezan Baig (Bloomberg)
On 2015/08/13 08:42:07, Shezan Baig (Bloomberg) wrote: > Hmm, I tried "git cl try" but ...
5 years, 4 months ago (2015-08-13 08:48:55 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 4 months ago (2015-08-13 08:50:02 UTC) #7
scottmg
lgtm
5 years, 4 months ago (2015-08-13 16:16:55 UTC) #8
Dirk Pranke
On 2015/08/13 08:48:55, Shezan Baig (Bloomberg) wrote: > On 2015/08/13 08:42:07, Shezan Baig (Bloomberg) wrote: ...
5 years, 4 months ago (2015-08-13 17:11:54 UTC) #9
Shezan Baig (Bloomberg)
On 2015/08/13 17:11:54, Dirk Pranke wrote: > On 2015/08/13 08:48:55, Shezan Baig (Bloomberg) wrote: > ...
5 years, 4 months ago (2015-08-13 17:17:25 UTC) #10
Shezan Baig (Bloomberg)
5 years, 4 months ago (2015-08-14 08:52:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
010fb9d696e7c79ffcbc4342efff3436cdc19f90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698