Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1288223003: Revert of add ConvertYUVAToARGBRow_MMX to media_perftests (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of add ConvertYUVAToARGBRow_MMX to media_perftests (patchset #3 id:40001 of https://codereview.chromium.org/1286913002/ ) Reason for revert: This broke the build: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20GN%20Clobber&number=3951 missing libyuv/basic_types.h Original issue's description: > Add YUVConvertPerfTest.ConvertYUVAToARGBRow_MMX and YUVConvertPerfTest.I422ToARGBRow_SSSE3 to media_perftests. > Fix math error when printing results by clearing the MMX state before doing float math. > BUG=libyuv:473 > > Committed: https://crrev.com/98e918a3abdfcc2eaae3df9cc3dd9f8225f39edc > Cr-Commit-Position: refs/heads/master@{#343140} TBR=dalecurtis@chromium.org,fbarchard@chromium.org,fbarchard@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=libyuv:473 Committed: https://crrev.com/11b2b77d5994b04e14ed79ac6e8b9e0586820d6c Cr-Commit-Position: refs/heads/master@{#343143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -50 lines) Patch
M media/base/yuv_convert_perftest.cc View 5 chunks +2 lines, -48 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of add ConvertYUVAToARGBRow_MMX to media_perftests
5 years, 4 months ago (2015-08-13 01:28:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288223003/1
5 years, 4 months ago (2015-08-13 01:28:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 01:29:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/11b2b77d5994b04e14ed79ac6e8b9e0586820d6c Cr-Commit-Position: refs/heads/master@{#343143}
5 years, 4 months ago (2015-08-13 01:29:31 UTC) #4
fbarchard
5 years, 4 months ago (2015-08-13 20:28:13 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698