Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288203002: Use warning icon in card unmask prompt. (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tfarina, rouslan+autofillwatch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use warning icon in card unmask prompt. BUG=505953 TBR=oshima@chromium.org Committed: https://crrev.com/e42e9c899b223e76a2a6feed935119cd5ef5ddb0 Cr-Commit-Position: refs/heads/master@{#343493}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
D chrome/app/theme/default_100_percent/common/alert_red.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/alert_red.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Evan Stade
5 years, 4 months ago (2015-08-12 21:24:35 UTC) #2
please use gerrit instead
lgtm I assume it looks correct.
5 years, 4 months ago (2015-08-12 21:51:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288203002/1
5 years, 4 months ago (2015-08-12 21:52:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288203002/20001
5 years, 4 months ago (2015-08-14 20:26:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 21:29:04 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 21:29:40 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e42e9c899b223e76a2a6feed935119cd5ef5ddb0
Cr-Commit-Position: refs/heads/master@{#343493}

Powered by Google App Engine
This is Rietveld 408576698